Skip to content

Jetpack Section: Scan - Push to the threat details view#15781

Merged
emilylaguna merged 4 commits intodevelopfrom
task/15190-threat-detail-history
Feb 4, 2021
Merged

Jetpack Section: Scan - Push to the threat details view#15781
emilylaguna merged 4 commits intodevelopfrom
task/15190-threat-detail-history

Conversation

@emilylaguna
Copy link
Copy Markdown
Contributor

Project #15190

This also hides the fix / ignore buttons for fixed / ignored threats.

To test:

  1. Launch the app
  2. Tap the My Site view
  3. Tap on a site with Jetpack Scan enabled
  4. Tap on Scan
  5. Tap on History
  6. Tap on a threat
  7. You should be pushed to the threat details view
  8. The fix / ignore buttons should not be visible

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 3, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 3, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@emilylaguna emilylaguna mentioned this pull request Feb 3, 2021
55 tasks
Copy link
Copy Markdown
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described!

@emilylaguna emilylaguna merged commit e4c0d92 into develop Feb 4, 2021
@emilylaguna emilylaguna deleted the task/15190-threat-detail-history branch February 4, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants