Jetpack Section: Scan: Push to the scan view from the Notifications#15779
Merged
emilylaguna merged 4 commits intodevelopfrom Feb 4, 2021
Merged
Jetpack Section: Scan: Push to the scan view from the Notifications#15779emilylaguna merged 4 commits intodevelopfrom
emilylaguna merged 4 commits intodevelopfrom
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
momo-ozawa
reviewed
Feb 3, 2021
Contributor
momo-ozawa
left a comment
There was a problem hiding this comment.
Works as described!
LGTM with one question.
Comment on lines
+88
to
+90
| case .scan: | ||
| try coordinator.displayScanWithSiteID(range.siteID) | ||
|
|
Contributor
There was a problem hiding this comment.
❓ Do we need to use a feature flag for this?
Contributor
Author
There was a problem hiding this comment.
🤦 I totally forgot to do that, I went back and added the checking if scan is available on the site with the intention of feature flagging it too but nope forgot..
Done in: a27feae
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project: #15190
Tapping on the threat notification will now push to the scan results view.
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.