Jetpack Section: Fix/Ignore Threat#15740
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
emilylaguna
left a comment
There was a problem hiding this comment.
Nice, works well. Added a comment below.
|
|
||
| // MARK: - Public | ||
|
|
||
| public func fixThreat() { |
There was a problem hiding this comment.
Hmm, I'm wondering if we could use a delegate attached to the JetpackScanViewController that triggers the fix / ignore methods since that view does a lot of heavy lifting for the fixing / ignoring.
Thoughts?
There was a problem hiding this comment.
Ahh, so that's why there was an ignoreThreat method already defined in JetpackScanCoordinator!
Makes sense to consolidate the fixing / ignoring in JetpackScanCoordinator.
Fixed! 2462d66
emilylaguna
left a comment
There was a problem hiding this comment.
Awesome, looks good! 🚢 👍
# Conflicts: # Podfile # Podfile.lock
Part of #15190
WPKit PR: wordpress-mobile/WordPressKit-iOS#339
Decription:
To test:
Fix threat
Fix threatbuttonCancelbutton on alertFix threatbutton, then tapOKbutton on alertIgnore threat
Ignore threatbuttonCancelbutton on alertIgnore threatbutton, then tapOKbutton on alertExample screenshots:
PR submission checklist:
RELEASE-NOTES.txtif necessary.