Skip to content

Jetpack Section: Scan: Adds loading and error handling#15726

Merged
emilylaguna merged 1 commit intodevelopfrom
task/15190-scan-loading
Jan 28, 2021
Merged

Jetpack Section: Scan: Adds loading and error handling#15726
emilylaguna merged 1 commit intodevelopfrom
task/15190-scan-loading

Conversation

@emilylaguna
Copy link
Copy Markdown
Contributor

@emilylaguna emilylaguna commented Jan 27, 2021

Project: #15190

Screenshots

General States

Loading Scan Failed To Start Generic Error No Internet
loading start error Simulator Screen Shot - iPhone 11 Pro - 2021-01-27 at 16 38 38 internet

To test:

  1. Launch the app, tap on the My Site, tap on a site with Jetpack Scan
  2. 👁️ The loading status
  3. Disable your internet
  4. Pull to refresh
  5. 👁️ The no internet status
  6. Enable internet
  7. Tap try again (it may take a minute or so for the connection to reestablish)
  8. 👁️ The view loads fine

The start scan error is very hard to reproduce, the only way I've been able to reproduce it is by changing my FTP credentials and triggering a scan.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@emilylaguna emilylaguna added this to the 16.7 milestone Jan 27, 2021
@emilylaguna emilylaguna self-assigned this Jan 27, 2021
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 27, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 27, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@emilylaguna emilylaguna mentioned this pull request Jan 28, 2021
Closed
55 tasks
momo-ozawa
momo-ozawa approved these changes Jan 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described! LGTM

@emilylaguna emilylaguna merged commit b9fb699 into develop Jan 28, 2021
@emilylaguna emilylaguna deleted the task/15190-scan-loading branch January 28, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandroalonso leandroalonso Awaiting requested review from leandroalonso

1 more reviewer

@momo-ozawa momo-ozawa momo-ozawa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@emilylaguna emilylaguna

Labels

Jetpack Mobile [Type] Task

Projects

None yet

Milestone

16.7

Development

Successfully merging this pull request may close these issues.

2 participants

@emilylaguna @momo-ozawa