Skip to content

Jetpack Section: Styles the threat cell#15677

Merged
emilylaguna merged 8 commits intodevelopfrom
task/15190-threat-style
Jan 21, 2021
Merged

Jetpack Section: Styles the threat cell#15677
emilylaguna merged 8 commits intodevelopfrom
task/15190-threat-style

Conversation

@emilylaguna
Copy link
Copy Markdown
Contributor

@emilylaguna emilylaguna commented Jan 20, 2021

Project: #15190

This PR adds the logic to determine which titles, descriptions, and icons to use depending on the threats status. The logic and wording comes directly from wp-calypso.

I also added some future properties to use on the Threat Details view.

Screenshots
Simulator Screen Shot - iPhone 11 Pro - 2021-01-20 at 17 33 48 Simulator Screen Shot - iPhone 11 Pro - 2021-01-20 at 17 34 01

To test:

  1. Launch the app
  2. Tap on the My Site view
  3. Tap on a site the has threats
  4. Swipe down to view all the threats

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@emilylaguna emilylaguna added this to the 16.6 milestone Jan 20, 2021
@emilylaguna emilylaguna self-assigned this Jan 20, 2021
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 20, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 20, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

momo-ozawa
momo-ozawa approved these changes Jan 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described! LGTM 👍

@emilylaguna emilylaguna merged commit 8132d8a into develop Jan 21, 2021
@emilylaguna emilylaguna deleted the task/15190-threat-style branch January 21, 2021 17:07
@emilylaguna emilylaguna mentioned this pull request Jan 22, 2021
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandroalonso leandroalonso Awaiting requested review from leandroalonso

1 more reviewer

@momo-ozawa momo-ozawa momo-ozawa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@emilylaguna emilylaguna

Labels

Jetpack Mobile [Type] Task

Projects

None yet

Milestone

16.6

Development

Successfully merging this pull request may close these issues.

2 participants

@emilylaguna @momo-ozawa