Jetpack Section: Add action to start the scan#15641
Merged
emilylaguna merged 18 commits intodevelopfrom Jan 14, 2021
Merged
Conversation
added 15 commits
January 13, 2021 12:40
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Contributor
leandroalonso
left a comment
There was a problem hiding this comment.
@emilylaguna worked as described. Left a few suggestions. :)
WordPress/Classes/ViewRelated/Jetpack/Jetpack Scan/JetpackScanCoordinator.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Jetpack/Jetpack Scan/JetpackScanCoordinator.swift
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Jetpack/Jetpack Scan/JetpackScanCoordinator.swift
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Jetpack/Jetpack Scan/JetpackScanStatusCell.swift
Show resolved
Hide resolved
leandroalonso
approved these changes
Jan 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project: #15190
This PR adds:
JetpackScanStatusViewModeland theJetpackScanCoordinatorScreenshots
scan.mov
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.