Skip to content

Handle malformed URLs in Xpost sites#15610

Merged
chipsnyder merged 1 commit intodevelopfrom
gutenberg/fix-xpost-urls
Jan 8, 2021
Merged

Handle malformed URLs in Xpost sites#15610
chipsnyder merged 1 commit intodevelopfrom
gutenberg/fix-xpost-urls

Conversation

@guarani
Copy link
Copy Markdown
Contributor

@guarani guarani commented Jan 8, 2021 •
edited
Loading

Addresses wordpress-mobile/gutenberg-mobile#2982

To test:

  1. Find a site that can Xpost to another site that has a blavatar URL that contains an <img> tag
  2. Make sure the Xpost UI loads correctly (the blavatar image for the site in question will not load as expected)

A proper placeholder image should be handled in a separate PR

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@guarani guarani requested a review from chipsnyder January 8, 2021 03:50
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 8, 2021 •
edited
Loading

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 40118. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 8, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@guarani
Copy link
Copy Markdown
Contributor Author

guarani commented Jan 8, 2021

Ping me if you need testing data to test this scenario.

@guarani guarani mentioned this pull request Jan 8, 2021
Merged
3 tasks
chipsnyder
chipsnyder approved these changes Jan 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my iPhone using some of the internal blogs. LGTM 🚢

@chipsnyder chipsnyder merged commit 6cf772d into develop Jan 8, 2021
@chipsnyder chipsnyder deleted the gutenberg/fix-xpost-urls branch January 8, 2021 21:53
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 8, 2021

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@chipsnyder chipsnyder added this to the 16.5 milestone Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chipsnyder chipsnyder chipsnyder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

16.5

Development

Successfully merging this pull request may close these issues.

2 participants

@guarani @chipsnyder