Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
momo-ozawa
left a comment
There was a problem hiding this comment.
@emilylaguna Works as described!
Added a couple of minor suggestions.
| init(blog: Blog, view: JetpackScanView, | ||
| service: JetpackScanService? = nil, | ||
| context: NSManagedObjectContext = ContextManager.sharedInstance().mainContext) { |
There was a problem hiding this comment.
[Nit]
Indentation alignment seems to be off, and the view: parameter would look better on its own line
There was a problem hiding this comment.
oops, thanks for the catch! Fixed in: d0f84cd
| tableView.register(UINib(nibName: String(describing: JetpackScanStatusCell.self), bundle: nil), | ||
| forCellReuseIdentifier: Constants.statusCellIdentifier) | ||
|
|
||
| tableView.register(UINib(nibName: String(describing: JetpackScanThreatCell.self), bundle: nil), | ||
| forCellReuseIdentifier: Constants.threatCellIdentifier) | ||
|
|
There was a problem hiding this comment.
What do you think of conforming to the NibReusable protocol for the cells?
| case error | ||
| } | ||
|
|
||
| private static func viewState(for scan: JetpackScan) -> StatusViewState { |
There was a problem hiding this comment.
Nice! makes it easy to follow how scan states map to view states ✨
| // IBOutlets | ||
| @IBOutlet weak var tableView: UITableView! | ||
|
|
||
| // |
Project: #15190
This adds the initial logic and view states for the scan status view.
No buttons work, and the scanning view doesn't display progress yet.
Idle
Scanning
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.