Skip to content

Activity Log: add tracks#15544

Merged
leandroalonso merged 4 commits intodevelopfrom
task/activity_log_filter_tracks
Dec 21, 2020
Merged

Activity Log: add tracks#15544
leandroalonso merged 4 commits intodevelopfrom
task/activity_log_filter_tracks

Conversation

@leandroalonso
Copy link
Copy Markdown
Contributor

Part of #15192

Adds analytics tracking to Activity Log filters.

To test

Selecting a date range

  1. Open Activity Log
  2. Tap "Date Range"
  3. Check that activitylog_filterbar_range_button_tapped is fired
  4. Select a date range and tap Done
  5. Make sure activitylog_filterbar_select_range is fired with distance and duration values
  6. Reset date range and tap Done
  7. Make sure activitylog_filterbar_reset_range is fired

Selecting a single date

  1. Open Activity Log
  2. Tap "Date Range"
  3. Select a date range and tap Done
  4. Open Date Range again
  5. Clear your selection
  6. Tap Done
  7. Make sure activitylog_filterbar_reset_range is fired

Selecting activity type

  1. Open Activity Log
  2. Tap "Activity Type"
  3. Make sure activitylog_filterbar_type_button_tapped is fired
  4. Select one or more activity types and tap done
  5. Make sure activitylog_filterbar_select_type is fired with props about the selected groups, number of groups and total number of activities
  6. Tap reset
  7. Make sure activitylog_filterbar_reset_type is fired

Clearing activity types

  1. Open Activity Log
  2. Tap "Activity Type"
  3. Select one or more activities type and tap done
  4. Tap "Activity Type" again
  5. Clear your selection and tap done
  6. Make sure activitylog_filterbar_reset_type is fired

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Copy Markdown
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Events are being fired as expected 👍

@leandroalonso leandroalonso merged commit 283db25 into develop Dec 21, 2020
@leandroalonso leandroalonso deleted the task/activity_log_filter_tracks branch December 21, 2020 12:40
@leandroalonso leandroalonso mentioned this pull request Dec 21, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants