Skip to content

Jetpack Section: New server credentials screen#15539

Closed
momo-ozawa wants to merge 2 commits intodevelopfrom
feature/15505-server-credentials-screen
Closed

Jetpack Section: New server credentials screen#15539
momo-ozawa wants to merge 2 commits intodevelopfrom
feature/15505-server-credentials-screen

Conversation

@momo-ozawa
Copy link
Copy Markdown
Contributor

@momo-ozawa momo-ozawa commented Dec 18, 2020 •
edited
Loading

Part of #15505

This PR adds a new Remote Server Credentials screen.

Please note that:

  • This screen is not yet hooked up to any APIs
  • Tapping on the cells won't do anything yet
  • The UI will be updated once design specs are finalized

To test:

  1. Make sure Jetpack Scan feature flag is turned ON
  2. Go to My Site > Jetpack Settings > Server Credentials
    • Should navigate to a new Remote Server Credentials screen ✅
Jetpack Settings Remote Server Credentials
Screen Shot 2020-12-18 at 18 35 57 Screen Shot 2020-12-18 at 18 36 01

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@momo-ozawa momo-ozawa added this to the Someday milestone Dec 18, 2020
@momo-ozawa momo-ozawa self-assigned this Dec 18, 2020
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Dec 18, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

momo-ozawa
momo-ozawa commented Dec 18, 2020
View reviewed changes
WordPress/Classes/ViewRelated/Jetpack/Server Credentials/ServerCredentialsViewController.swift
*/
}

private func credentialsViewModel(_ credentials: JetpackScanCredentials? = nil) -> ImmuTable {
Copy link
Copy Markdown
Contributor Author

@momo-ozawa momo-ozawa Dec 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing an optional JetpackScanCredentials for now, until I'm able to hook up the endpoints

@momo-ozawa momo-ozawa changed the title Feature/15505 server credentials screen Jetpack Section: New server credentials screen Dec 18, 2020
@momo-ozawa momo-ozawa mentioned this pull request Dec 18, 2020
Open
11 tasks
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Dec 18, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@momo-ozawa momo-ozawa closed this Dec 22, 2020
@momo-ozawa momo-ozawa deleted the feature/15505-server-credentials-screen branch March 29, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilylaguna emilylaguna Awaiting requested review from emilylaguna

@yaelirub yaelirub Awaiting requested review from yaelirub

@leandroalonso leandroalonso Awaiting requested review from leandroalonso

Assignees

@momo-ozawa momo-ozawa

Labels

Jetpack [Type] Task

Projects

None yet

Milestone

Someday

Development

Successfully merging this pull request may close these issues.

1 participant

@momo-ozawa