Skip to content

Activity Log: fix calendar device rotation#15537

Merged
leandroalonso merged 2 commits intodevelopfrom
task/fix_calendar_device_rotation
Dec 18, 2020
Merged

Activity Log: fix calendar device rotation#15537
leandroalonso merged 2 commits intodevelopfrom
task/fix_calendar_device_rotation

Conversation

@leandroalonso
Copy link
Copy Markdown
Contributor

@leandroalonso leandroalonso commented Dec 17, 2020

Part of #15192

To test

No dates selected

  1. Go to Activity Log and open the calendar filter
  2. Rotate the device
  3. Check that it still displays the last month
  4. Rotate again, check that it still displays the last month

Dates selected

  1. Go to Activity Log and open the calendar filter
  2. Select a single date or a date range
  3. Rotate the device
  4. Check that it scrolls to your date selection
  5. Rotate again, check that it still scrolls to your date selection

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@leandroalonso leandroalonso added this to the 16.5 milestone Dec 17, 2020
@leandroalonso leandroalonso self-assigned this Dec 17, 2020
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Dec 17, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@leandroalonso leandroalonso mentioned this pull request Dec 17, 2020
Closed
13 tasks
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Dec 17, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

momo-ozawa
momo-ozawa approved these changes Dec 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@momo-ozawa momo-ozawa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works as described ✨ 💯
Tested on iPhone SE and iPad Air 4.

@leandroalonso leandroalonso merged commit f9bdad9 into develop Dec 18, 2020
@leandroalonso leandroalonso deleted the task/fix_calendar_device_rotation branch December 18, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@momo-ozawa momo-ozawa momo-ozawa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@leandroalonso leandroalonso

Labels

Activity Log [Type] Task

Projects

None yet

Milestone

16.5

Development

Successfully merging this pull request may close these issues.

2 participants

@leandroalonso @momo-ozawa