Activity Log filters: improve accessibility#15534
Merged
leandroalonso merged 3 commits intodevelopfrom Dec 18, 2020
Merged
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
13 tasks
momo-ozawa
approved these changes
Dec 18, 2020
Contributor
momo-ozawa
left a comment
There was a problem hiding this comment.
LGTM! 👍
Tested on iPhone SE and iPad Air 4.
One small thing I noticed:
- When you double tap to activate the
reset filterbutton, VoiceOver reads out thereset filterbutton again but then gets cut off when the reset button disappears
Contributor
Author
I added a line of code to move the focus to the main button, but it's still gets cut off. I'm going ahead and merging that but please do let me know if you have any idea how to solve that. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #15192
Improves accessibility to Activity Log filter bar.
To test
Please, test using a real device with voice over enabled.
Filter bar
Date Range
Z gesture:
Selecting date:
Reset button:
Activity Type
Z gesture:
Selecting activities:
Reset button:
PR submission checklist:
RELEASE-NOTES.txtif necessary.