Skip to content

Activity Log filters: improve accessibility#15534

Merged
leandroalonso merged 3 commits intodevelopfrom
task/activity_log_filter_accessivbility
Dec 18, 2020
Merged

Activity Log filters: improve accessibility#15534
leandroalonso merged 3 commits intodevelopfrom
task/activity_log_filter_accessivbility

Conversation

@leandroalonso
Copy link
Copy Markdown
Contributor

Part of #15192

Improves accessibility to Activity Log filter bar.

To test

Please, test using a real device with voice over enabled.

Filter bar

  1. Go to Activity Log
  2. Check that both the Date Range button and Activity Type button are accessible

Date Range

Z gesture:

  1. Tap the Date Range button
  2. Use the Z gesture (with two fingers), the screen should be dismisses

Selecting date:

  1. Tap the Date Range button
  2. Check that every date cell is read by Voice Over (the complete date)
  3. Select a date range
  4. Go to the header and make sure voice over read it's contents
  5. Tap Done

Reset button:

  1. Check that the voice over reads the reset button

Activity Type

Z gesture:

  1. Tap the Activity Type button
  2. Use the Z gesture (with two fingers), the screen should be dismisses

Selecting activities:

  1. Tap the Activity Type button
  2. Select one or more activity types
  3. Tap Done

Reset button:

  1. Check that the voice over reads the reset button

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Dec 17, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Dec 17, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@leandroalonso leandroalonso mentioned this pull request Dec 17, 2020
13 tasks
Copy link
Copy Markdown
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
Tested on iPhone SE and iPad Air 4.

One small thing I noticed:

  • When you double tap to activate the reset filter button, VoiceOver reads out the reset filter button again but then gets cut off when the reset button disappears

@leandroalonso
Copy link
Copy Markdown
Contributor Author

When you double tap to activate the reset filter button, VoiceOver reads out the reset filter button again but then gets cut off when the reset button disappears

I added a line of code to move the focus to the main button, but it's still gets cut off. I'm going ahead and merging that but please do let me know if you have any idea how to solve that. :)

@leandroalonso leandroalonso merged commit e0884cb into develop Dec 18, 2020
@leandroalonso leandroalonso deleted the task/activity_log_filter_accessivbility branch December 18, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants