Activity Log: filter by activity type#15440
Merged
leandroalonso merged 32 commits intodevelopfrom Dec 8, 2020
Merged
Conversation
…_log_filter_activity_type
|
You can trigger an installable build for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
houndci-bot
reviewed
Dec 4, 2020
WordPress/WordPressTest/Activity/ActivityListViewModelTests.swift
Outdated
Show resolved
Hide resolved
emilylaguna
suggested changes
Dec 4, 2020
WordPress/Classes/ViewRelated/Activity/ActivityListViewModel.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Activity/ActivityListViewModel.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Activity/ActivityListViewModel.swift
Outdated
Show resolved
Hide resolved
WordPress/WordPressTest/Activity/ActivityListViewModelTests.swift
Outdated
Show resolved
Hide resolved
Contributor
Author
@emilylaguna, this is a simulator issue. Sometimes when you toggle your connection on/off the simulator does not follow, I tested here and it's working fine. (We had that issue all the time during the Offline Support project) |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
emilylaguna
approved these changes
Dec 7, 2020
Contributor
emilylaguna
left a comment
There was a problem hiding this comment.
Working well for me! 🚢
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Part of #15192
Adds the feature to filter activities by activity type.
The filter bar/chips design is not part of this task.
To test
Filtering by any activity type
Reopening the Activity type screen
Reseting activity type
Activity type with a date range filter
Multiple activity types
Test more!
Please, test other types of combination of date range + activity types. :)
PR submission checklist:
RELEASE-NOTES.txtif necessary.