Skip to content

Activity Log: filter by activity type#15440

Merged
leandroalonso merged 32 commits intodevelopfrom
task/activity_log_filter_activity_type
Dec 8, 2020
Merged

Activity Log: filter by activity type#15440
leandroalonso merged 32 commits intodevelopfrom
task/activity_log_filter_activity_type

Conversation

@leandroalonso
Copy link
Copy Markdown
Contributor

Part of #15192

Adds the feature to filter activities by activity type.

The filter bar/chips design is not part of this task.

To test

Filtering by any activity type

  1. Open Activity Log
  2. Tap "Activity Type"
  3. Select just one activity type and tap Done
  4. Note that the button label changes to match the activity you selected
  5. The results should reflect only activities of the type you selected

Reopening the Activity type screen

  1. Tap the Activity type button again
  2. The screen should show the activity types right away, without reloading
  3. The activity type you selected should be selected
  4. Tap "Done"
  5. Nothing should happen since you selected the same filter as before

Reseting activity type

  1. Click the "X" near the activity type button
  2. All activities types should be displayed

Activity type with a date range filter

  1. Select a date range that you know will have results, tap Done
  2. Tap the Activity Type button
  3. Activity types that match your selected date range should appear
  4. Select one and tap done
  5. Check that the results are from your selected activity type and between your selected range

Multiple activity types

  1. Open the Activity type screen again
  2. Select more than one activity type and tap Done
  3. Check that the button now displays "Activity Type (X)" where X is the number of activity types you selected

Test more!

Please, test other types of combination of date range + activity types. :)

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Dec 4, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

Copy link
Copy Markdown
Contributor

@emilylaguna emilylaguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this is working pretty well! I left a couple comments and saw 1 weird issue:

  • After I triggered the no results view by disabling my internet, instead of a loading view I see the error view:

@leandroalonso
Copy link
Copy Markdown
Contributor Author

After I triggered the no results view by disabling my internet, instead of a loading view I see the error view:

@emilylaguna, this is a simulator issue. Sometimes when you toggle your connection on/off the simulator does not follow, I tested here and it's working fine. (We had that issue all the time during the Offline Support project)

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Dec 7, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Copy Markdown
Contributor

@emilylaguna emilylaguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well for me! 🚢

@leandroalonso leandroalonso merged commit a7a1e67 into develop Dec 8, 2020
@leandroalonso leandroalonso deleted the task/activity_log_filter_activity_type branch December 8, 2020 00:28
@leandroalonso leandroalonso mentioned this pull request Dec 15, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants