Merged
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
houndci-bot
reviewed
Dec 1, 2020
WordPress/Classes/ViewRelated/Gutenberg/Utils/GutenbergFilesAppMediaSource.swift
Outdated
Show resolved
Hide resolved
This was referenced Dec 1, 2020
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
guarani
approved these changes
Dec 4, 2020
WordPress/Classes/ViewRelated/Gutenberg/Processors/GutenbergAudioUploadProcessor.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Gutenberg/Processors/GutenbergAudioUploadProcessor.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Gutenberg/Processors/GutenbergAudioUploadProcessor.swift
Outdated
Show resolved
Hide resolved
…dioUploadProcessor.swift Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com>
…dioUploadProcessor.swift Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com>
…dioUploadProcessor.swift Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com>
Contributor
Author
|
Thank you @guarani 🙏 |
This was referenced Dec 17, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gutenbergPR: WordPress/gutenberg#27401gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#2854This PR implements the Audio upload processor to be used together with the Audio block.
This PR also improves the file type filet for the on-device file picker: Now only file extensions allowed by the blog can be picked. Previously any video/image extensions could be picked for the Audio/Video blocks. This is also now used on the Audio block to avoid Apple-only audio filetypes (common on audio files recorded in iPhones).
To test:
Test running metro server on wordpress-mobile/gutenberg-mobile#2854
srcURL is a remote (non-local) URL.cc @jd-alexander
PR submission checklist:
RELEASE-NOTES.txtif necessary.