Skip to content

Activity Log: Date filter#15412

Merged
leandroalonso merged 24 commits intodevelopfrom
task/activity_log_date_range_filter
Dec 2, 2020
Merged

Activity Log: Date filter#15412
leandroalonso merged 24 commits intodevelopfrom
task/activity_log_date_range_filter

Conversation

@leandroalonso
Copy link
Copy Markdown
Contributor

@leandroalonso leandroalonso commented Nov 30, 2020 •
edited
Loading

Part of #15192

Adds the feature to filter activities by a date range.

The filter bar/chips design is not part of this task.

To test

Selecting a range

  1. Open Activity Log
  2. Tap "Date Range" at the top
  3. Select two different dates
  4. Check that the results match your selected dates

Calendar keeps the selected dates

  1. Tap the dates you selected at the top
  2. Check that the Calendar opens with your previously selection
  3. Tap Cancel
  4. Nothing happens

Removing the date filter

  1. Tap the "X" button at the filter bar
  2. Checks that the filtering is reset

No results

  1. Tap "Date Range" at the top
  2. Select a range date in December (or any other you're sure won't return results)
  3. The screen should display an error message: "No matching events found."

Single date

  1. Clear the filter
  2. Open the calendar
  3. Select a single date
  4. Check that results are returned

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@leandroalonso
Create activity log's filter feature flag
5da74fc
@leandroalonso
Adds the filter stack view based on the FF value
549bc95
@leandroalonso
Update refreshActivities to accept a before and after date
4d31b6a
@leandroalonso
Update loadMoreActivities to accept date range
5dff2a1
@leandroalonso
Changes loadMore to use the date range to filter results
2e3adf4
@leandroalonso
Filter results based on the selected date
8d8fdf8
@leandroalonso
Adds a structure for the filter bar
a71161a
@leandroalonso
Fix constraints warnings
2b7d7f5
@leandroalonso
Create a filter chip button that displays a X to erase it's value
c35343a
@leandroalonso
Add the date filter and display the correct labels
82ae85d
@leandroalonso
Change how noResultsViewController is added/removed to keep just one …
0abbe8c 
…single instance
@leandroalonso
Add resetActivities action
0bbc3bc
@leandroalonso
When filtering results, remove the current activities
2409181
@leandroalonso
Merge branch 'task/add_year_calendar' into task/activity_log_date_ran…
e301478 
…ge_filter
@leandroalonso
Show error when there are no activities for a given date range
43e4773
@leandroalonso leandroalonso added this to the 16.4 milestone Nov 30, 2020
@leandroalonso leandroalonso self-assigned this Nov 30, 2020
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Nov 30, 2020 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Nov 30, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

emilylaguna
emilylaguna suggested changes Dec 1, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@emilylaguna emilylaguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looking good. I hit a few issues when testing the filtering:

If I select single date, I expected to see results only for that date, but I am seeing results from other days as well:

If I select a date range in the past (ex: April 1st 2015 to April 7th 2015) it is not scrolled into view upon closing, then reopening the calendar.

If I select Nov 28th to Nov 30th I see results from Nov 27th, Nov 28th but nothing else.

If one of the selected dates is not from this year we should show the year for both the dates.

Screen Shot 2020-12-01 at 2 38 02 PM

I suspect most of the issues can be resolved by including a time in the after before query fields which is what .com includes.

after=2015-11-07 05:00:00&before=2020-11-15 04:59:59

@leandroalonso
Copy link
Copy Markdown
Contributor Author

leandroalonso commented Dec 2, 2020

@emilylaguna ready for another review. :)

@leandroalonso leandroalonso mentioned this pull request Dec 2, 2020
Merged
emilylaguna
emilylaguna suggested changes Dec 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@emilylaguna emilylaguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Made a couple of comments below.

Also we discussed this but I'll mention it here as well, when rotating the device to/from landscape the view scrolls to the very first date so Dec 2000

emilylaguna
emilylaguna approved these changes Dec 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@emilylaguna emilylaguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@leandroalonso leandroalonso merged commit 72afe5b into develop Dec 2, 2020
@leandroalonso leandroalonso deleted the task/activity_log_date_range_filter branch December 2, 2020 21:28
@leandroalonso
Copy link
Copy Markdown
Contributor Author

leandroalonso commented Dec 3, 2020

Also we discussed this but I'll mention it here as well, when rotating the device to/from landscape the view scrolls to the very first date so Dec 2000

I've added a task to check that again in #15192

@leandroalonso leandroalonso mentioned this pull request Dec 15, 2020
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@emilylaguna emilylaguna emilylaguna approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@leandroalonso leandroalonso

Labels

Activity Log [Type] Task

Projects

None yet

Milestone

16.4

Development

Successfully merging this pull request may close these issues.

2 participants

@leandroalonso @emilylaguna