Skip to content

[Gutenberg] File block - Implementing WP media picker source#15291

Merged
jd-alexander merged 9 commits intogutenberg/after_1.42.0from
gutenberg/file-block-III-wp-media-picker
Nov 26, 2020
Merged

[Gutenberg] File block - Implementing WP media picker source#15291
jd-alexander merged 9 commits intogutenberg/after_1.42.0from
gutenberg/file-block-III-wp-media-picker

Conversation

@etoledom
Copy link
Copy Markdown
Contributor

@etoledom etoledom commented Nov 13, 2020 •
edited
Loading

gutenberg PR: WordPress/gutenberg#26960
gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2805

Implementing WP Media Library source for File block

IMG_300098FE578A-1

To test:

  • Create a new post.
  • Add a file block.
  • Press on Choose a file.
    • Check that the option WordPress Media Library is present.
  • Select such option.
    • Check that all kind of files are present to be selected (such as images, videos, audios, PDFs, etc...)
  • Select any of these files.
    • Check that the file is immediately added to the block.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@etoledom etoledom self-assigned this Nov 13, 2020
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Nov 13, 2020 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@etoledom etoledom added the Gutenberg Editing and display of Gutenberg blocks. label Nov 13, 2020
@etoledom etoledom added this to the 16.3 milestone Nov 13, 2020
This was referenced Nov 13, 2020
Merged
Merged
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Nov 13, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@jd-alexander jd-alexander mentioned this pull request Nov 18, 2020
Merged
3 tasks
@etoledom etoledom marked this pull request as ready for review November 18, 2020 10:13
@etoledom etoledom requested a review from guarani November 18, 2020 10:13
@jd-alexander
Copy link
Copy Markdown
Contributor

jd-alexander commented Nov 19, 2020

@etoledom for this modal, are you planning to add the "Choose file" title similar to the design in a separate PR? Just checking because the Android UI needs updating to fit the spec of other bottom sheets within the editor.

@etoledom
Copy link
Copy Markdown
Contributor Author

etoledom commented Nov 19, 2020 •
edited
Loading

are you planning to add the "Choose file" title similar to the design in a separate PR?

Good catch!
This I believe can be added on gutenberg and the title will be present for both platforms. I'll take a look 👍

guarani
guarani approved these changes Nov 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me 👍. Will a tagged version of Gutenberg be needed when this is merged?

@etoledom etoledom modified the milestones: 16.3, 16.4 Nov 24, 2020
@etoledom etoledom changed the base branch from develop to gutenberg/after_1.42.0 November 24, 2020 08:09
@jd-alexander jd-alexander merged commit 566bb25 into gutenberg/after_1.42.0 Nov 26, 2020
@jd-alexander jd-alexander deleted the gutenberg/file-block-III-wp-media-picker branch November 26, 2020 05:22
@cameronvoell cameronvoell mentioned this pull request Dec 1, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@guarani guarani guarani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@etoledom etoledom

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Milestone

16.4

Development

Successfully merging this pull request may close these issues.

3 participants

@etoledom @jd-alexander @guarani