Conversation
Stats, Activity log, Jetpack settings (which include security settings and manage connection) - Added tracks
moved jetpack settings under new folder.
|
You can trigger an installable build for these changes by visiting CircleCI here. |
houndci-bot
reviewed
Nov 13, 2020
WordPress/Classes/ViewRelated/Jetpack/Jetpack Settings/JetpackSettingsViewController.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Jetpack/Jetpack Settings/JetpackSettingsViewController.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Jetpack/Jetpack Settings/JetpackSettingsViewController.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Jetpack/Jetpack Settings/JetpackSettingsViewController.swift
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@emilylaguna, in addition to the code review and described testing could you please also:
|
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
emilylaguna
reviewed
Nov 13, 2020
emilylaguna
suggested changes
Nov 13, 2020
Contributor
emilylaguna
left a comment
There was a problem hiding this comment.
tl;dr Works well! Great job! Left a couple comments below.
Tested on:
- iPhone 11 Pro - 14.0
- iPad Air - 12.4
- iPhone 5s 11.4
Jetpack Section
- Verified the Activity Log option Jetpack section is visible for sites that support Activity Log, Stats, or have Jetpack settings
- Verified the Jetpack Settings does not appear for sites that don't support it
- Verified the Jetpack section is not visible if the site doesn't support Activity Log (meetomattic)
- Verified each item in the section works
Jetpack Settings
- Verified each option correctly changes the value on WP.com, tested by changing each option and verifying on Calypso
- Verified Manage Connection will disconnect your site
Quick Start
- Tested each step in Quick Start
- Found 1 issue not related to this PR
Events: Tested and verified the following tracks are being fired
| Event | When | |
|---|---|---|
| ✅ | jetpack_settings_viewed | When tapping on the 'Jetpack Settings' option |
| ✅ | jetpack_manage_connection_viewed | When tapping on the 'Manage connection' option |
| ✅ | jetpack_disconnect_tapped | When tapping the 'Disconnect' button on Manage Connection |
| ✅ | jetpack_disconnect_requested | When tapping Disconnect on the confirmation alert |
WordPress/Classes/ViewRelated/Blog/Blog Details/BlogDetailsViewController.m
Outdated
Show resolved
Hide resolved
| NSParameterAssert(blog); | ||
|
|
||
| JetpackSecuritySettingsViewController *settings = [[JetpackSecuritySettingsViewController alloc] initWithBlog:blog]; | ||
| JetpackSettingsViewController *settings = [[JetpackSettingsViewController alloc] initWithBlog:blog]; |
Contributor
There was a problem hiding this comment.
Do we still need the 'Security' and 'Manage Connection' options on the Site Settings?
Contributor
Author
There was a problem hiding this comment.
As described, i chose to to keep them there for now. I can imagine that in the future we will remove them
…SettingsViewController
50f62e6 to
cbe1804
Compare
Contributor
Author
|
Ready for another look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15275
This PR groups Stats, Activity log and Jetpack Settings in the Jetpack section.
Jetpack settings have been extracted from site settings and now exist in both places.
This PR also renames
JetpackSecuritySettingsViewControllertoJetpackSettingsViewControllerand groups the the related classes under a new subfolder - Jetpack Settings
New Tracks:
jetpack_settings_viewed
jetpack_manage_connection_viewed
jetpack_disconnect_tapped
jetpack_disconnect_requested - (User selected disconnect in alert)
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.