[Gutenberg] UBE: Pressenting Jetpack Security settings on Missing Block by etoledom · Pull Request #14880 · wordpress-mobile/WordPress-iOS

etoledom · 2020-09-11T10:52:10Z

Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2610

This PR implements changes from wordpress-mobile/gutenberg-mobile#2610 to present the Jetpack Security settings modally over Gutenberg, and refresh the editor capabilities to enable the Unsupported Block Editor.

NOTE: The action button text for UBE Enabled has been updated to Edit using web editor.

To test:

All tests must be run with metro running on Overwrite Missing block UI Text gutenberg-mobile#2610

Jetpack connected sites (Self-Hosted and Atomic)

Have a Jetpack connected site with a post with an unsupported block on it.
Be sure to have SSO disabled for this site.
Open the post with the mobile app.
Press the (?) button on the missing block.
- Check that the bottom sheet looks like the one from the image Jetpack - UBE Disabled.
Press the action button Open Jetpack security settings.
Check that the Jetpack Security Settings appears modally.
Activate the option Allow WordPress.com login and press Done.
Press (?) button again.
- Check that now the bottom sheet has changes, and looks like Jetpack - UBE Enabled from the image.
Press again the action button Edit using web editor.
- Check that UBE works as expected. (If its a new site, you might need to allow WordPress.com login on the web view. This is expected behaviour.

Self-Hosted sites.

Add a self-hosted site to the mobile app (not connected to wpcom).
Open a post with an unsupported block in it.
Press the (?) button on the missing block.
- Check that it looks like the one from the image Self-Hosted - Disabled.

WPCom Simple sites.

On a WPCom Simple site:
Open a post with an unsupported block in it.
Press the (?) button on the missing block.
- Check that it looks like the one from the image WPCom Simple - Enabled.
Press the action button Edit using web editor.
- Check that UBE loads as expected.

PR submission checklist:

I have considered adding unit tests where possible.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

…k-sso-enabled

…ted-block-editor-jetpack-sso-enabled

…and be able to edit unsupported blocks on web view

WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift

peril-wordpress-mobile · 2020-09-11T10:52:17Z

You can trigger an installable build for these changes by visiting CircleCI here.

peril-wordpress-mobile · 2020-09-11T11:16:38Z

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

jkmassel · 2020-09-21T19:09:51Z

👋 We're freezing 15.8 today, so I'm bumping this PR forward to 15.9. If you need it to be part of the 15.8 release cycle, please merge to the release/15.8 branch and DM me – I'll be happy to cut a new beta release!

…ted-block-editor-switch-to-enable-jetpack-sso

marecar3 · 2020-09-24T23:19:18Z

Hey 👋 @etoledom
I have updated gb-mobile reference to the latest and changed this PR to ready for review if that is ok?

WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift

guarani · 2020-09-25T02:04:52Z

WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift

        return [
            .mentions: post.blog.isAccessibleThroughWPCom() && FeatureFlag.gutenbergMentions.enabled,
            .unsupportedBlockEditor: isUnsupportedBlockEditorEnabled,
+            .unsupportedBlockEditorSwitch: post.blog.jetpack?.isConnected ?? false,


I'm wondering if something like unsupportedBlockEditorRequiresUserInteraction would be more descriptive?

Also, now that we're handling Jetpack sites here, should we remove this comment:

WordPress-iOS/WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift

Line 922 in 0416d76

// Jetpack sites with SSO disabled also have Unsupported Block Editor disabled, since we won't be able to authenticate to their self-hosted site.

These names are really tricky 😬
So, this capability is about the site being able to enable Unsupported Blocks Editor if it's disabled.
This would be the general description to no mention SSO or Jetpack. That's why it's true for any Jetpack site, even if SSO is already active and it doesn't require user interaction.

Maybe a better name could be unsupportedBlockEditorSwitchable or ...Activable? 🤔
I really don't like this "capability" but we need this information.

From WordPress/gutenberg#25238 (comment)
Maybe unsupportedBlockEditorCanBeEnabled could also work for the capability name 🤔
Wdyt?

cc @marecar3 - since we might need to change the capability name in both platforms

That's why it's true for any Jetpack site, even if SSO is already active and it doesn't require user interaction.

True, so unsupportedBlockEditorRequiresUserInteraction wouldn't work either.

I really don't like this "capability" but we need this information.

It seems like it isn't a "capability", but I don't know where else we could put it either.

Hah yeah, that sounds right. It's more a capability of the site that's using using Gutenberg rather than of gutenberg itself.
This feels more like a property of the Unsupported Block Editor capability.

guarani

I tested all three scenarios and this works great! 🎉 I've commented on a couple of things above, but they are relatively minor.

It's worth noting that from the Jetpack settings modal screen, I can pretty much navigate anywhere (e.g. sign up for a Jetpack account) — I'm not sure if we want to block those off somehow (otherwise users may get lost).

WordPress/Classes/ViewRelated/Gutenberg/GutenbergWeb/GutenbergWebViewController.swift

Remove trailing empty space (Hound lint)

etoledom and others added 7 commits August 4, 2020 12:01

Enabling Unsupported Block Editor for Jetpack sites with SSO enabled.

b19daf2

Fetching Jetpack settings when editor loads

cc0eaf2

Merge branch 'develop' into gutenberg/unsupported-block-editor-jetpac…

cc81a72

…k-sso-enabled

Update gutenberg reference

5cfd8cd

Update gb-reference

d3875f1

Merge remote-tracking branch 'origin/develop' into gutenberg/unsuppor…

4b7494e

…ted-block-editor-jetpack-sso-enabled

[Gutenberg] UBE: Pressenting Jetpack Security settings to enable SSO …

67039f1

…and be able to edit unsupported blocks on web view

houndci-bot reviewed Sep 11, 2020

View reviewed changes

WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift Outdated Show resolved Hide resolved

etoledom mentioned this pull request Sep 11, 2020

Overwrite Missing block UI Text wordpress-mobile/gutenberg-mobile#2610

Merged

2 tasks

etoledom self-assigned this Sep 11, 2020

etoledom added the Gutenberg Editing and display of Gutenberg blocks. label Sep 11, 2020

etoledom added this to the 15.8 milestone Sep 11, 2020

etoledom mentioned this pull request Sep 11, 2020

[RNMobile] Overwrite Missing block Alert Strings WordPress/gutenberg#25238

Merged

6 tasks

etoledom force-pushed the gutenberg/unsupported-block-editor-jetpack-sso-enabled branch from 84fbdc3 to e1960f0 Compare September 14, 2020 06:52

Base automatically changed from gutenberg/unsupported-block-editor-jetpack-sso-enabled to develop September 14, 2020 09:07

jkmassel modified the milestones: 15.8, 15.9 Sep 21, 2020

etoledom added 3 commits September 22, 2020 17:53

Update gutenberg ref

8deaa63

Merge remote-tracking branch 'origin/develop' into gutenberg/unsuppor…

26de3e4

…ted-block-editor-switch-to-enable-jetpack-sso

Fix hound lint

2c815bc

marecar3 requested a review from guarani September 24, 2020 22:58

marecar3 added 3 commits September 24, 2020 19:11

Update gutenberg-mobile reference

9a7b622

Merge

864e911

Update gutenberg-mobile reference

dd0af5e

marecar3 marked this pull request as ready for review September 24, 2020 23:19

guarani reviewed Sep 25, 2020

View reviewed changes

WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift Outdated Show resolved Hide resolved

guarani reviewed Sep 25, 2020

View reviewed changes

guarani self-requested a review September 25, 2020 02:56

guarani approved these changes Sep 25, 2020

View reviewed changes

etoledom added 5 commits September 25, 2020 08:43

Gutenberg: Jetpack setting handler function name change

2f9c465

Update gutenberg ref

fcf6168

Gutenberg: Remove comments not longer relevant

a64f51e

Update gutenberg ref

ee4f4c2

Gutenberg Web: Activating Continue button just when Gutenberg has loaded

06f9030

houndci-bot reviewed Sep 25, 2020

View reviewed changes

WordPress/Classes/ViewRelated/Gutenberg/GutenbergWeb/GutenbergWebViewController.swift Outdated Show resolved Hide resolved

etoledom added 5 commits September 25, 2020 11:54

Update GutenbergWebViewController.swift

023d0fc

Remove trailing empty space (Hound lint)

Update gutenberg ref

7b8ee66

Update gutenberg ref

34005dd

Update gutenberg ref

6b275eb

Update gutenberg ref

fb7e293

etoledom merged commit b3bfb13 into develop Sep 28, 2020

etoledom deleted the gutenberg/unsupported-block-editor-switch-to-enable-jetpack-sso branch September 28, 2020 11:10

Conversation

etoledom commented Sep 11, 2020 • edited by guarani Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

To test:

Jetpack connected sites (Self-Hosted and Atomic)

Self-Hosted sites.

WPCom Simple sites.

Uh oh!

Uh oh!

peril-wordpress-mobile bot commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peril-wordpress-mobile bot commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jkmassel commented Sep 21, 2020

Uh oh!

marecar3 commented Sep 24, 2020

Uh oh!

Uh oh!

guarani Sep 25, 2020

Choose a reason for hiding this comment

Uh oh!

guarani Sep 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

etoledom Sep 25, 2020

Choose a reason for hiding this comment

Uh oh!

etoledom Sep 25, 2020

Choose a reason for hiding this comment

Uh oh!

etoledom Sep 25, 2020

Choose a reason for hiding this comment

Uh oh!

guarani Sep 25, 2020

Choose a reason for hiding this comment

Uh oh!

etoledom Sep 25, 2020

Choose a reason for hiding this comment

Uh oh!

guarani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

etoledom commented Sep 11, 2020 •

edited by guarani

Loading

peril-wordpress-mobile bot commented Sep 11, 2020 •

edited

Loading

peril-wordpress-mobile bot commented Sep 11, 2020 •

edited

Loading

guarani Sep 25, 2020 •

edited

Loading