Skip to content

Enable editing of unsupported blocks#14403

Merged
etoledom merged 7 commits intodevelopfrom
gutenberg/unsupported-fallback-remove-dev-only-flag
Jul 2, 2020
Merged

Enable editing of unsupported blocks#14403
etoledom merged 7 commits intodevelopfrom
gutenberg/unsupported-fallback-remove-dev-only-flag

Conversation

@guarani
Copy link
Copy Markdown
Contributor

@guarani guarani commented Jun 30, 2020 •
edited
Loading

Related wordpress-mobile/gutenberg-mobile#2457

To test: See WordPress/gutenberg#23592

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jun 30, 2020 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jun 30, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@guarani guarani changed the title Gutenberg/unsupported fallback remove dev only flag Enable editing of unsupported blocks Jun 30, 2020
@guarani guarani mentioned this pull request Jun 30, 2020
Merged
6 tasks
@etoledom etoledom force-pushed the gutenberg/unsupported-fallback-remove-dev-only-flag branch from caf10db to e7a48fd Compare July 1, 2020 09:31
@etoledom etoledom self-requested a review July 1, 2020 09:34
@etoledom etoledom added the Gutenberg Editing and display of Gutenberg blocks. label Jul 1, 2020
@etoledom etoledom added this to the 15.3 milestone Jul 1, 2020
@etoledom etoledom marked this pull request as ready for review July 1, 2020 09:37
@etoledom etoledom requested a review from marecar3 July 1, 2020 09:42
@marecar3
Copy link
Copy Markdown
Contributor

marecar3 commented Jul 1, 2020

Hey @etoledom should we update release notes?

etoledom added 2 commits July 1, 2020 17:01
@etoledom
Update gutenberg ref
5c86f8f
@etoledom
[Gutenberg]: Enabling Unsupported Block Editor in WPCom and Self-Host…
bc8f0a9 
…ed sites.

On Jetpack sites it remains disabled because of auth issues
@etoledom
Copy link
Copy Markdown
Contributor

etoledom commented Jul 1, 2020

Updated this PR deactivating the Unsupported Block Editor feature if the site is connected via Jetpack, using the changes from here: WordPress/gutenberg#23592 (comment)

Jetpack-connected sites will be recognised as wpcom site by our auth algorithm, but since we use the self-hosted url to load gutenberg, the cookies obtained won't work.

We should request the cookies using the self-hosted way, but being logged-in on Wpcom account, we don't have the self-hosted username and password required for this to work.

While we can't solve this problem, we won't be able to edit unsupported blocks on Jetpack sites.

@etoledom
Copy link
Copy Markdown
Contributor

etoledom commented Jul 1, 2020 •
edited
Loading

Steps to test:

  • Create a wpcom account+site
  • Create a self-hosted site
  • Connect your self-hosted site to the wpcom account
  • Create a second self-hosted site.
  • Add this last self-hosted site to the app as a self-hosted (non-jetpack) site.
  • Create a new post with an Unsupported block to all three sites.
  • check that:
    • WPCom site shows the feature and Gutenberg-Web loads as expected.
    • Self-Hosted site shows the feature and Gutenberg-Web loads as expected.
    • Jetpack site does not show the feature.

cc @guarani @marecar3

etoledom
etoledom approved these changes Jul 1, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected on my tests:

  • Main test WPCom account
  • New WPCom account
  • Self-Hosted: WP Versions: 5.0.10 5.1.6 5.2.7 5.3.4 5.4.2
  • Jetpack site: Feature disabled.

Waiting for confirmation from @guarani about the last change and I believe we are good to go on WPiOS.

guarani
guarani commented Jul 1, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test results

Self-hosted site: nervous-crane.jurassic.ninja

✅ Editing an unsupported block works fine.

Jetpack connected site: reluctant-kestrel.jurassic.ninja

✅ There is no option to edit unsupported blocks on Jetpack connected self-hosted sites, as expected per comment above.

WP.com site: pschrottkyubp.wordpress.com

✅ Editing an unsupported block works fine.

@etoledom etoledom merged commit ffdf4d6 into develop Jul 2, 2020
@etoledom etoledom deleted the gutenberg/unsupported-fallback-remove-dev-only-flag branch July 2, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marecar3 marecar3 Awaiting requested review from marecar3

1 more reviewer

@etoledom etoledom etoledom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@guarani guarani

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Milestone

15.3

Development

Successfully merging this pull request may close these issues.

3 participants

@guarani @marecar3 @etoledom