Skip to content

Issue/13063 insert captions#13903

Merged
SergioEstevao merged 4 commits intodevelopfrom
issue/13063_insert_captions
Apr 20, 2020
Merged

Issue/13063 insert captions#13903
SergioEstevao merged 4 commits intodevelopfrom
issue/13063_insert_captions

Conversation

@SergioEstevao
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao commented Apr 15, 2020

Fixes #13603

This PR inserts media captions defined in the site MediaLibrary when adding image blocks on the Gutenberg editor and on the Aztec editor.

To test:

  • Start the app
  • Start a new post in GB
  • Add an image block
  • Add an image of the WP media library that has a caption defined ( you can define it on the Media section of the site)
  • Check that the image is added and the caption is set
  • Do the same test using Aztec

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added this to the 14.7 milestone Apr 15, 2020
@SergioEstevao SergioEstevao requested a review from ceyhun April 15, 2020 13:15
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Apr 15, 2020 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Apr 15, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@SergioEstevao SergioEstevao mentioned this pull request Apr 15, 2020
Merged
2 tasks
ceyhun
ceyhun approved these changes Apr 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@loremattei loremattei modified the milestones: 14.7 ❄️, 14.8 Apr 20, 2020
@loremattei
Copy link
Copy Markdown
Contributor

loremattei commented Apr 20, 2020

Hey! I'm moving this to 14.8 because 14.8 has been cut. If you want this to make it to 14.7, please feel free to ping me.

@SergioEstevao
Merge branch 'develop' into issue/13063_insert_captions
4f9c0bc 
# Conflicts:
#	Podfile
#	Podfile.lock
@SergioEstevao SergioEstevao merged commit e33b243 into develop Apr 20, 2020
@SergioEstevao SergioEstevao deleted the issue/13063_insert_captions branch April 20, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ceyhun ceyhun ceyhun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

14.8

Development

Successfully merging this pull request may close these issues.

3 participants

@SergioEstevao @loremattei @ceyhun