Adds analytics for the Post Signup Interstitial#13505
Merged
emilylaguna merged 1 commit intofeature/post-signup-interstitialfrom Feb 19, 2020
Merged
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
ScoutHarris
approved these changes
Feb 19, 2020
Contributor
ScoutHarris
left a comment
There was a problem hiding this comment.
✅ When the PSI is displayed
✅ Tap the create site button
✅ Tap the add self-hosted site button
✅ Tap the Not Right Now option
LGTM!
![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12880
Shared PR: wordpress-mobile/WordPress-iOS-Shared#249
To test:
Launch the app
If you're logged in, log out
Tap Continue with WordPress.com
Login to an account that has no sites
When the PSI is displayed, verify this in the console:
🔵 Tracked: welcome_no_sites_interstitial_shownTap the create site button, and verify this in the console:
🔵 Tracked: welcome_no_sites_interstitial_button_tapped <button: create_new_site>Tap the add self-hosted site button, and verify this in the console:
🔵 Tracked: welcome_no_sites_interstitial_button_tapped <button: add_self_hosted_site>Tap the Not Right Now option, and verify this in the console:
🔵 Tracked: welcome_no_sites_interstitial_dismissedNote: In order to test each button option you will need to either:
PR submission checklist:
RELEASE-NOTES.txtif necessary.