Merged
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
# Conflicts: # Podfile # Podfile.lock
Update Aztec to version 1.15.0 and matching Gutenberg version.
maxme
suggested changes
Jan 23, 2020
Contributor
maxme
left a comment
There was a problem hiding this comment.
I checked the margin and I smoke tested the editor. Everything look fine.
I don't see any changes to ChangeLog (should we mention the updated margins and crash fix?).
Same comment I had in wpandroid about the shortcode, I think we should mention the new shortcode block, even if it was released in 14.0.
@SergioEstevao were you trying to fix the UI tests?
Contributor
|
I updated the release notes in cfdcc87 |
SergioEstevao
approved these changes
Jan 23, 2020
Contributor
SergioEstevao
left a comment
There was a problem hiding this comment.
Working well for me, just needs the merge conflict to be sorted out and 
!
Contributor
Author
|
Thank you @SergioEstevao for fixing the UI Tests issue! And both of you for the review 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1788
PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.