[Gutenberg] Send http status code to network error callback.#13119
[Gutenberg] Send http status code to network error callback.#13119
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
|
||
| private func dotComPath(with dotComID: NSNumber) -> String { | ||
| return path.replacingOccurrences(of: "/wp/v2/", with: "/wp/v2/sites/\(dotComID)/") | ||
| return path.replacingOccurrences(of: "/wp/v2/", with: "/wp/v2/sitesa/\(dotComID)/") |
There was a problem hiding this comment.
Is this correct: sitesa ?
There was a problem hiding this comment.
Oh no! I changed that to test the error code. Didn't change it back 😬
Fixed now!
SergioEstevao
left a comment
There was a problem hiding this comment.
So using an WP.com atomic test site, I'm unable to see the image being loaded again after I come back online.
But I'm unable to change the image size settings, I see 4 options: Thumbnail, Medium, Large, Full, but when I select any of of the values I always get Large as result.
This was probably because of the typo introduced in the path. Sorry about that! |
SergioEstevao
left a comment
There was a problem hiding this comment.
Working great now! 
|
Hey! I moved this to 14.1 because 14.0 has been cut. Please, ping me if you want it to make it to 14.0 😀 |
|
Hey! I moved this to 14.2 because 14.1 has been cut. Please, ping me if you want it to make it to 14.1 😀 |
gutenberg-mobileside PR: wordpress-mobile/gutenberg-mobile#1686This PR ensures that the real http status code is returned on the network error callback.
To test:
PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.