Update Podfile to support RN-0.61#13116
Merged
hypest merged 11 commits intogutenberg/after-1.21.0from Jan 24, 2020
Merged
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
1 task
1 task
# Conflicts: # Podfile # Podfile.lock
# Conflicts: # Podfile # Podfile.lock
# Conflicts: # Podfile # Podfile.lock
etoledom
approved these changes
Jan 23, 2020
Contributor
etoledom
left a comment
There was a problem hiding this comment.
- Project builds and run! 🎉
- Gutenberg opens and works well 🎉 🎉
rm -rf Pods was needed to properly run rake dependencies, other than that, everything looks great .
🎉 🎉 🎉
Contributor
|
Let's wait for the WPiOS code freeze to merge this, or target and merge to |
…_0.61 # Conflicts: # Podfile # Podfile.lock
Contributor
|
Yeap, let's target the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the RN libraries references in the podfile Gutenberg section to make sure they follow the new names and needs of the new version.
To test:
rm -Rf Pods. This updates brings a a lot of pod change for RN so it's better to start with a clean folder.rake dependenciesPR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.