Skip to content

[VoiceOver] Self-hosted Login Flow enhancements#13099

Merged
shiki merged 1 commit intodevelopfrom
issue/13086-self-hosted-voiceover
Dec 16, 2019
Merged

[VoiceOver] Self-hosted Login Flow enhancements#13099
shiki merged 1 commit intodevelopfrom
issue/13086-self-hosted-voiceover

Conversation

@shiki
Copy link
Copy Markdown
Contributor

@shiki shiki commented Dec 13, 2019 •
edited
Loading

Fixes #13086. Fixes #12188.

Please see wordpress-mobile/WordPressAuthenticator-iOS#170 for testing and reviewing. 🙂

Reviewer Checklist

Submitter Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
  • If it's feasible, I have added unit tests.
  • Update this PR to use a pod release version

@shiki shiki added this to the 13.9 milestone Dec 13, 2019
@shiki shiki self-assigned this Dec 13, 2019
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Dec 13, 2019 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@shiki shiki mentioned this pull request Dec 13, 2019
Merged
5 tasks
@shiki shiki marked this pull request as ready for review December 13, 2019 21:05
@shiki shiki requested a review from mindgraffiti December 13, 2019 21:05
@shiki shiki changed the title [VoiceOver] Set Authenticator to use dev branch [VoiceOver] Self-hosted Login Flow enhancements Dec 13, 2019
@pinarol pinarol modified the milestones: 13.9, 14.0 Dec 16, 2019
@pinarol
Copy link
Copy Markdown
Contributor

pinarol commented Dec 16, 2019

Hey there! I've moved this to 14.0 since 13.9 has been cut. If you want this to make it to 13.9, please feel free to ping me.

mindgraffiti
mindgraffiti approved these changes Dec 16, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@mindgraffiti mindgraffiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Thanks Jayson

:shipit:

@shiki shiki force-pushed the issue/13086-self-hosted-voiceover branch from 6b682e4 to 88e3913 Compare December 16, 2019 19:43
@shiki shiki merged commit cf022c5 into develop Dec 16, 2019
@shiki shiki deleted the issue/13086-self-hosted-voiceover branch December 16, 2019 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mindgraffiti mindgraffiti mindgraffiti approved these changes

Assignees

@shiki shiki

Labels

Login Self-hosted

Projects

None yet

Milestone

14.0

Development

Successfully merging this pull request may close these issues.

[VoiceOver] Add Self-hosted Site page concerns Update error message when entering an invalid site address

3 participants

@shiki @pinarol @mindgraffiti