You can trigger an installable build for these changes by visiting CircleCI here.

Generated by 🚫 dangerJS

@lukewalczak this is coming along very nicely. Here are a few notes I made as feedback during testing (on WPiOS via the build mentioned above):

• Color settings informational bottom sheet: We can remove the single-quote marks from the title. Right now it says 'Color Settings' aren't yet supported... – it can just be Color settings aren't yet supported.... We can probably also remove the description below that. (screenshot)
• The left/right padding on the button seems a bit too much. What are the paddings set at? IIRC the figma component has 16px.
• Link rel value placeholder should be None instead of Add URL (screenshot)
• Tapping on the link rel input is causing weird flickering/freezing issues (video for example)

• Link bottom sheet causes a similar freeze/crash (video for example)

Let me know if you have any questions!

Thanks for a feedback @iamthomasbishop!

Color settings informational bottom sheet: We can remove the single-quote marks from the title. Right now it says 'Color Settings' aren't yet supported... – it can just be Color settings aren't yet supported.... We can probably also remove the description below that.

Ok, I'll adjust it according to your suggestion.

The left/right padding on the button seems a bit too much. What are the paddings set at? IIRC the figma component has 16px.

Actually, horizontal paddings have 16px, however RichText itself has also some space. Please look at the screenshots:

paddings - one character | paddings - more characters |
paddings - empty rich text | no paddings
--- | --- | --- | ---
| | |

Link rel value placeholder should be None instead of Add URL

Will change it!

Flickering / freezing issues

Working over that, however, as I mentioned on slack we will not face these issues once we choose an approach where only when user tap directly the RichText within the Button it will be focused (still tapping outside the Button area will select that block).
That approach is bug-less and following the web approach. What's more it can be confusing for a user that keyboard is opening on taping the Button block once user wanted eg change the border radius.

Let me know what do you think!

Actually, horizontal paddings have 16px, however RichText itself has also some space. Please look at the screenshots:

Ahhh, that makes sense (that extra spacing issue has been creeping up in a bunch of places 😞 ). I think we're solving it elsewhere, so no need to change here.

Your notes regarding tapping directly on RichText vs the block boundary makes sense. Although I think most users will expect that an initial on the button itself will focus it, I think once they're familiar of the concept of blocks and can see where the boundaries are, it'll be more obvious. I'll keep an eye on this during upcoming usability tests.

LGTM! Tested with the steps I mentioned in the gutenberg PR.

But, since the release branch is cut, we should merge into gutenberg/after_1.22.0 instead of develop.

(Another option is waiting until the release branch is merged into develop again which will happen next Monday)