[Gutenberg] Fix guten-gallery image size.#13042
Merged
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
1 task
pinarol
approved these changes
Dec 6, 2019
Contributor
There was a problem hiding this comment.
This is fixing the low resolution image issue on Gallery bock
I also tested size options on Image block and they work as expected.
Image caching is also improved by including the size into cache key.
We can 
after adding some description
Thanks @etoledom for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with gallery blocks, where the image downloaded is of a noticeable lower quality than the expected:
Expected:
Actual result:
To test:
PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.