Use new .org api client for Gutenberg networking#13020
Merged
SergioEstevao merged 14 commits intodevelopfrom Mar 26, 2020
Merged
Use new .org api client for Gutenberg networking#13020SergioEstevao merged 14 commits intodevelopfrom
SergioEstevao merged 14 commits intodevelopfrom
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
1 task
pinarol
reviewed
Dec 2, 2019
9521b56 to
72baa79
Compare
72baa79 to
879f824
Compare
# Conflicts: # Podfile # Podfile.lock # WordPress/Classes/ViewRelated/Gutenberg/GutenbergNetworking.swift
# Conflicts: # Podfile # Podfile.lock
# Conflicts: # Podfile # Podfile.lock
Contributor
Contributor
|
Hey! I moved this PR to 14.6 as because 14.5 has been cut. If you want this to make it to 14.5, please feel free to ping me! |
etoledom
approved these changes
Mar 25, 2020
Contributor
etoledom
left a comment
There was a problem hiding this comment.
Approved via wordpress-mobile/WordPressKit-iOS#202 (review). Looking great!
# Conflicts: # Podfile # Podfile.lock
3 tasks
# Conflicts: # Podfile # Podfile.lock
And if not make sure completion object is called with failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See wordpress-mobile/WordPressKit-iOS#202 for description and testing instructions.
PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.