Skip to content

Enable Spacer block in production#12970

Closed
geriux wants to merge 3 commits intodevelopfrom
update-gutenberg-spacer-block
Closed

Enable Spacer block in production#12970
geriux wants to merge 3 commits intodevelopfrom
update-gutenberg-spacer-block

Conversation

@geriux
Copy link
Copy Markdown
Contributor

@geriux geriux commented Nov 19, 2019

Updates Gutenberg so the Spacer block is available in production.

Gutenberg-> WordPress/gutenberg#18605

To test:

  • Run the app without metro running
  • Start a new post
  • Select the Spacer block
    • Change the height of the Spacer
    • Move the block between other ones and check it works correctly
    • Remove the block
    • Add one again
  • Save as draft
  • Open your draft and check the Spacer block is shown correctly

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Nov 19, 2019 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

This was referenced Nov 19, 2019
Merged
Merged
@geriux geriux marked this pull request as ready for review November 19, 2019 14:04
@geriux geriux requested a review from pinarol November 19, 2019 14:04
@geriux geriux added the Gutenberg Editing and display of Gutenberg blocks. label Nov 19, 2019
@geriux geriux added this to the 13.8 milestone Nov 19, 2019
@geriux geriux requested review from SergioEstevao and removed request for pinarol November 20, 2019 10:10
SergioEstevao
SergioEstevao approved these changes Nov 20, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great in iOS.

Tested all scenarios indicated on the tests and it works great.

@geriux geriux closed this Nov 25, 2019
@geriux geriux deleted the update-gutenberg-spacer-block branch November 25, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees

No one assigned

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Milestone

13.8 ❄️

Development

Successfully merging this pull request may close these issues.

2 participants

@geriux @SergioEstevao