You can test the changes on this Pull Request by downloading it from HockeyApp here. If you need access to this, you can ask a maintainer to add you.

Generated by 🚫 dangerJS

Looking good @cameronvoell, nice work! I just have a couple bits of feedback:

• Sometimes the transition from the canvas to the image preview is abrupt, not using a cross-fade. It seems this usually happens on the first attempt after adding an image to canvas.
• Can we dismiss the preview on tap? If we were showing information/UI around the image then I'd propose the tap gesture would toggle visibility of that, but since we're not showing anything let's have tap dismiss the preview UI.
• It'd be great to allow omnidirectional drag to dismiss, but I don't think that's a blocker to ship v1.

Sometimes the transition from the canvas to the image preview is abrupt, not using a cross-fade. It seems this usually happens on the first attempt after adding an image to canvas.

Notes for future self on things I tried in order to fix this:

• Tried forcing the image preview to always source from cache and not from the network (https://facebook.github.io/react-native/docs/images#cache-control-ios-only)
• Tried modal prop useNativeDriver = true
• Tried updating react-native-modal to latest version: 11.5.3 ( in combination with above as well)
• Tried tweaking increasing/decreasing times of backdropTransitionInTiming

I'm still working on this. The first couple parameter tweaks etc. did not seem to help. See the video below. I agree it is not a good first animation.

@cameronvoell One tiny other thing I forgot to mention, is there a way we can remove the image outline (thick blue border) while the upload is progressing? I think the outline should only be applied once the image is successfully uploaded.

I also noticed in your last video above that the progress bar jumps to the bottom of the area when, mostly as the upload is finishing.

Separate issue, which I created here: The icon used on the placeholder background could use some tweaks. This is especially jarring because there's some jumpiness in displaying the image.

Closed in favor of native iOS solution: #12979