Merged
Conversation
* This is due to Giphy's recent SDK change that requires opting in to Apple's advertising identifier system when submitting the app. * We'll either remove Giphy completely in a future update or look at options for reintroducing it or another gif provider.
etoledom
approved these changes
Oct 24, 2019
Contributor
etoledom
left a comment
There was a problem hiding this comment.
Looks good! 🎉
Sad to remove this option though.
The project builds and the options of Gifs as media source are not there anymore.
To fix the error shasum: WARNING: 1 computed checksum did NOT match from CI, it might be helpful to delete the local Pods folder and run rake dependencies again.
Let's
after the CI is happy ✅
2 tasks
Closed
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Giphy recently updated their SDK, which now requires opting into use an advertising identifier and serve advertisements. We don't want to do this, so this PR removes Giphy as a user-facing Gif import option and our dependency on the Giphy SDK.
In a future PR we'll either look at removing the rest of the integration or repurposing it for a different gif provider.
To test:
+and then...on the format bar and ensure Giphy doesn't show as an optionUpdate release notes:
RELEASE-NOTES.txtif necessary.