Skip to content

Remove Giphy dependency#12769

Merged
loremattei merged 4 commits intorelease/13.4.1from
remove-giphy
Oct 25, 2019
Merged

Remove Giphy dependency#12769
loremattei merged 4 commits intorelease/13.4.1from
remove-giphy

Conversation

@frosty
Copy link
Copy Markdown
Contributor

@frosty frosty commented Oct 24, 2019

Giphy recently updated their SDK, which now requires opting into use an advertising identifier and serve advertisements. We don't want to do this, so this PR removes Giphy as a user-facing Gif import option and our dependency on the Giphy SDK.

We serve sponsored content every now and then so we can continue building great products and sharing the joy of GIFs across the Internet, and in apps like yours.

As a result, you’ll have to check a few boxes when you submit your app for review on the App Store if you’ve integrated this SDK.

Answer yes when asked if the app uses an advertising identifier and be sure to check:
    - Serve advertisements within the app
    - Attribute an action taken within this app to a previously served advertisement

In a future PR we'll either look at removing the rest of the integration or repurposing it for a different gif provider.

To test:

  • Rake dependencies
  • Build and run, check it builds okay
  • In the Media Library, tap + and ensure Giphy doesn't show as an option
  • In Aztec, tap the + and then ... on the format bar and ensure Giphy doesn't show as an option

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

* This is due to Giphy's recent SDK change that requires opting in to
  Apple's advertising identifier system when submitting the app.
* We'll either remove Giphy completely in a future update or look at
  options for reintroducing it or another gif provider.
@frosty frosty added the Giphy label Oct 24, 2019
@frosty frosty added this to the 13.4.1 milestone Oct 24, 2019
@frosty frosty requested review from etoledom and loremattei October 24, 2019 13:50
Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉
Sad to remove this option though.

The project builds and the options of Gifs as media source are not there anymore.

To fix the error shasum: WARNING: 1 computed checksum did NOT match from CI, it might be helpful to delete the local Pods folder and run rake dependencies again.

Let's :shipit: after the CI is happy ✅

@loremattei loremattei added Giphy and removed Giphy labels Oct 24, 2019
@loremattei loremattei merged commit 0e910ec into release/13.4.1 Oct 25, 2019
@loremattei loremattei deleted the remove-giphy branch October 25, 2019 14:40
@scihant scihant mentioned this pull request Nov 23, 2019
@ScoutHarris ScoutHarris mentioned this pull request Apr 2, 2020
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants