Better Error Messaging for Invalid URLs#11563
Merged
diegoreymendez merged 6 commits intodevelopfrom Apr 25, 2019
Merged
Conversation
Contributor
Author
|
Waiting until the tests succeed before submitting for review. Sorry about the early assignments. |
mindgraffiti
approved these changes
Apr 25, 2019
Contributor
mindgraffiti
left a comment
There was a problem hiding this comment.
code ✅
unit tests ✅
UI test ✅ (I used xcode.wtf and then https://xcode.wtf after, because non-standard TLD)
Thank you for fixing the CocoaLumberjack issue @diegoreymendez 🌟
Contributor
Author
|
Oh sorry, it seems I caused some trouble with the assignments. Thank you very much @mindgraffiti ! |
designsimply
reviewed
May 8, 2019
Contributor
designsimply
left a comment
There was a problem hiding this comment.
👍 LGTM! I tested this in 12.4 beta and just wanted to drop in my screenshots from testing:
Tested with WP Internal 12.4.0.20190505 on iPhone 6S iOS 12.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10294
This PR implements improved error messaging for invalid URLs input by the user into the "Login with Site Address" option.
This PR also removes
Debounceras it was moved to the shared pod.This PR also integrates several new pods and completes the update to CocoaLumberjack 3.5.2.
Demo
Testing
Update release notes:
RELEASE-NOTES.txt.