Merged
Conversation
pinarol
approved these changes
Mar 7, 2019
Contributor
pinarol
left a comment
There was a problem hiding this comment.
LGTM! 👍
Below are done:
Check that wordpress-mobile/gutenberg-mobile#603 and wordpress-mobile/gutenberg-mobile#693 are solved.
Smoke test around to see if everything seems right.
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the gutenberg ref for testing v1.0.2
Changes:
Issue/fix caret updates gutenberg-mobile#694
To test:
rake dependencies.Note: The only change from 1.0.1 is that hot fix, nothing else we have been working on the last week has been included.
cc @loremattei , @koke , @hypest