Hey @iamthomasbishop 👋 You can request a new build from this PR's branch and start reviewing the style

Changes look nice! I think the text-shadow might be a tiny bit too strong, but it at least is better than no visual difference. Are we using straight css to apply this? If so, what are the values?

One other thing I noticed: When I try go to HTML Mode and change a header, from an h2 to h5 by editing the markup, when I switch back to Visual Mode, that change isn't visualized.

Hey @iamthomasbishop thanks for the feedback.

Are we using straight css to apply this? If so, what are the values?

We aren't using css, We are doing this on native side with NSShadow, it has basically 3 parameters:

shadow-x-offset: Horizontal growing amount for shadow, this is determined with the if-else I am putting below
shadow-y-offset: Vertical growing amount for shadow, this is set to 0 in our case.
shadow-blur-radius: This is also 0 for our case because we don't want blur in order to mimic the extra boldness.

here is how shadow-x-offset is calculated with respect to the font size:

           if fontSize >= 22 {
                return 0.82
            } else if fontSize >= 20 && fontSize < 22 {
                return 0.78
            } else if fontSize >= 18 && fontSize < 20 {
                return 0.75
            } else if fontSize >= 16 && fontSize < 18 {
                return 0.72
            } else {
                return 0.7
            }

We can play with these values to find the best result.

One other thing I noticed: When I try go to HTML Mode and change a header, from an h2 to h5 by editing the markup, when I switch back to Visual Mode, that change isn't visualized.

I guess you did this on Gutenberg editor right? If so, it is because we don't support h5 in GB, if you were in debug mode you'd see a validation error about it. I tried with one of the supported values and worked fine:

here is how shadow-x-offset is calculated with respect to the font size:

Ok, thanks for the explanation! Does that code you shared above only apply to headings, or any text with those fontSizes?

I do think we could pull back on the shadow slightly (~.1 less), but what we have now isn't terrible. Maybe we could try:

if fontSize >= 22 {
    return 0.72
} else if fontSize >= 20 && fontSize < 22 {
    return 0.68
} else if fontSize >= 18 && fontSize < 20 {
    return 0.65
} else if fontSize >= 16 && fontSize < 18 {
    return 0.62
} else {
    return 0.6
}

I guess you did this on Gutenberg editor right? If so, it is because we don't support h5 in GB

That's correct. I just found it a little odd – but something we can address separately maybe.

Does that code you shared above only apply to headings, or any text with those fontSizes?

Only headings. We don't use shadow effect at any other type of text, other type of texts won't get effected.

I'll update the PR with those values you suggested and let you know @iamthomasbishop

Hey @iamthomasbishop 👋 I've updated the values, this is ready to give another try.