Skip to content

Gutenberg - Scroll to caret while typing#10826

Merged
pinarol merged 9 commits intodevelopfrom
gutenberg/follow-cursor-on-typing
Jan 22, 2019
Merged

Gutenberg - Scroll to caret while typing#10826
pinarol merged 9 commits intodevelopfrom
gutenberg/follow-cursor-on-typing

Conversation

@pinarol
Copy link
Copy Markdown
Contributor

@pinarol pinarol commented Jan 15, 2019

Fixes: wordpress-mobile/gutenberg-mobile#464

This PR adds ability to follow caret when typing position goes under the keyboard.

caret-follow3

caret-follow4

To Test:

Prerequisites

  • Run rake dependencies
  • Clean Xcode build folder(Product>clean build folder) <<< Important

Follow steps on gutenberg-mobile PR

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@pinarol pinarol added the Gutenberg Editing and display of Gutenberg blocks. label Jan 15, 2019
@pinarol pinarol added this to the 11.7 milestone Jan 15, 2019
@pinarol pinarol self-assigned this Jan 15, 2019
@pinarol pinarol requested a review from etoledom January 15, 2019 17:14
@wpmobilebot
Copy link
Copy Markdown
Contributor

1 Warning
⚠️ Podfile: reference to a commit hash

Generated by 🚫 Danger

@pinarol
Copy link
Copy Markdown
Contributor Author

pinarol commented Jan 21, 2019

@etoledom I think this is ready for a final look

Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

The caret fix is there just with metro running on gutenberg-mobile:develop.
The JSBundle can be updated later on with the next gutenberg-mobile version.

Thank you @pinarol !

@pinarol pinarol merged commit 76904c4 into develop Jan 22, 2019
@pinarol pinarol deleted the gutenberg/follow-cursor-on-typing branch January 22, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants