Skip to content

Gutenberg - Scroll to caret position on focused field#10730

Merged
pinarol merged 8 commits intodevelopfrom
issue/gb-432-scroll-to-cursor
Jan 4, 2019
Merged

Gutenberg - Scroll to caret position on focused field#10730
pinarol merged 8 commits intodevelopfrom
issue/gb-432-scroll-to-cursor

Conversation

@pinarol
Copy link
Copy Markdown
Contributor

@pinarol pinarol commented Jan 2, 2019

Fixes wordpress-mobile/gutenberg-mobile#436 wordpress-mobile/gutenberg-mobile#432

Adds ability to scroll to caret. More detailed description can be found in gutenberg-mobile PR.

To Test

Testing Prerequisites

  • Checkout the branch, run rake dependencies in terminal
  • Open WPiOS with Xcode
  • Choose Product > Clean build folder (not vital but just in case)
  • Tap Play button with a simulator selected on its right

Test the scenario in wordpress-mobile/gutenberg-mobile#436

Test other test cases in child PR

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@wpmobilebot
Copy link
Copy Markdown
Contributor

1 Warning
⚠️ Podfile: reference to a commit hash

Generated by 🚫 Danger

@pinarol pinarol added Gutenberg Editing and display of Gutenberg blocks. and removed [Status] Not Ready for Review labels Jan 2, 2019
@pinarol pinarol changed the title Scroll to caret position on focused field Gutenberg - Scroll to caret position on focused field Jan 2, 2019
Note: I will update the podfile to use the new dependency as a gutenberg_pod after I make a new version for react-native-keyboard-aware-scroll-view
@pinarol
Copy link
Copy Markdown
Contributor Author

pinarol commented Jan 3, 2019

I have added the new native call in a separate pod. I will update the podfile to use the new dependency as a gutenberg_pod after I make a new version for react-native-keyboard-aware-scroll-view

Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved here and here .

Let's :shipit: !

Thank you @pinarol !

@pinarol pinarol merged commit fc40629 into develop Jan 4, 2019
@SergioEstevao SergioEstevao deleted the issue/gb-432-scroll-to-cursor branch November 8, 2019 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants