Skip to content

Proposal: Use system-defined grays for Tooltip and Snackbar components' #14136

@iamthomasbishop

Description

@iamthomasbishop

Over on the Mobile Gutenberg project, we've been working on a RN-based tooltip and I noticed that the new native Tooltip components for WPiOS (and WPAndroid) use Color Studio grays, which conflicts a bit with our preference of using system-defined grays.

Considering both WPiOS and WPAndroid are both using system-defined grays, I think we might as well change the background-color on both the Tooltip and Snackbar components to use the following colors on iOS (from the HIG), inverted for each mode (light mode using a dark mode gray and vice versa):

  • Light mode: Use dark-mode values of systemGray5 or systemGray6
  • Dark mode: Use light-mode values of systemGray5 or systemGray6

Note: we can't exactly use dynamic system colors on RN, but we can target the default system grays separately with static hex or RGB values for each platform. So if this proposal is accepted, I'll likely propose doing so on RN. // cc @geriux

CC'ing @mattmiklic @osullivanchris @bjtitus for feedback and discussion. 😄

Metadata

Metadata

Assignees

Labels

[Status] Needs DiscussionThe issue needs to be discussed by the team before it can be resolved.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions