Android 13 migration update compile sdk version to 33#122
Merged
ravishanker merged 3 commits intotrunkfrom Mar 15, 2023
Merged
Conversation
Update from 31 to 33
Add try, catch since it now throws an Exception on release
7 tasks
fluiddot
reviewed
Mar 14, 2023
WordPressUtils/src/main/java/org/wordpress/android/util/ImageUtils.java
Outdated
Show resolved
Hide resolved
irfano
approved these changes
Mar 15, 2023
Member
There was a problem hiding this comment.
LGTM! I made a simple smoke test. Also, I didn't see any critical warnings. 👍🏻
@ravishanker, I don't see any blocker for merging this, but I have seen the [PR] Not Ready for Merge label. Feel free to merge it if there is no blocker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update compileSdkVersion to 33
Internal project thread: pbArwn-5IN-p2
Fixes: #18095