MediaFile - Add large and medium URLs#108
Merged
Merged
Conversation
This was referenced Jun 30, 2022
c21fa5d to
4df023a
Compare
derekblank
approved these changes
Jul 14, 2022
derekblank
left a comment
There was a problem hiding this comment.
I was able to test and verify the steps following the Testing Instructions on WordPress/gutenberg#42178. LGTM! 🚀
mkevins
reviewed
Jul 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
WordPress Android PR-> Media - Add large and medium image sizes WordPress-Android#16875Description
This PR adds the
largeandmediumsizes for theMediaFile, needed for the editor's Image and Gallery block.It also adds the
getOptimalFileURLmethod to get the optimal image URL.To test
Check the WordPress Android PR description.