Skip to content

Removes Deprecated Display functions#106

Merged
ashiagr merged 2 commits intotrunkfrom
issue/16073-replace-deprecated-display-apis-with-windowmetrics-apis
Jun 2, 2022
Merged

Removes Deprecated Display functions#106
ashiagr merged 2 commits intotrunkfrom
issue/16073-replace-deprecated-display-apis-with-windowmetrics-apis

Conversation

@AjeshRPai
Copy link
Copy Markdown
Contributor

@AjeshRPai AjeshRPai commented Jun 2, 2022

This PR removes the deprecated functions from the Library.

Context

The Display functions for getting the size of the Display were deprecated in the Android 11 and Instead, the Window metrics were introduced for replacing them.

  • As part of the Migration to Android 12 the window metrics APIs were added to the Utils library in this PR
  • The usages of the deprecated display functions were removed from the WooCommerce Android repo in this PR
  • The usages of the deprecated display functions were removed from the Wordpress Android repo in this PR

Testing Instructions

  • Make sure that only deprecated functions were removed.

@AjeshRPai AjeshRPai self-assigned this Jun 2, 2022
@AjeshRPai AjeshRPai requested a review from ashiagr June 2, 2022 10:28
@AjeshRPai AjeshRPai marked this pull request as ready for review June 2, 2022 10:28
@ashiagr ashiagr self-assigned this Jun 2, 2022
Copy link
Copy Markdown
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for removing deprecated functions.

@ashiagr ashiagr merged commit 70badd4 into trunk Jun 2, 2022
@ashiagr ashiagr deleted the issue/16073-replace-deprecated-display-apis-with-windowmetrics-apis branch June 2, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants