Conversation
…'s in the settings
irfano
left a comment
There was a problem hiding this comment.
I left some comments and questions, and I haven't approved the PR yet in case you want to make changes.
mediapicker/domain/src/main/java/org/wordpress/android/mediapicker/model/MediaType.kt
Show resolved
Hide resolved
mediapicker/src/main/java/org/wordpress/android/mediapicker/viewmodel/MediaPickerViewModel.kt
Outdated
Show resolved
Hide resolved
mediapicker/src/main/java/org/wordpress/android/mediapicker/viewmodel/MediaPickerViewModel.kt
Outdated
Show resolved
Hide resolved
|
@irfano Thanks for your patience. I went back and streamlined the way permissions are being requested and ended up refactoring and removing some redundant code. Ready for another round. |
irfano
left a comment
There was a problem hiding this comment.
Thank you for the new commits in response to my comment. I have reviewed all of them, and they have resolved my concerns.
I have added some further comments and questions for your attention.
mediapicker/src/main/java/org/wordpress/android/mediapicker/viewmodel/MediaPickerViewModel.kt
Outdated
Show resolved
Hide resolved
mediapicker/domain/src/main/java/org/wordpress/android/mediapicker/api/MediaPickerSetup.kt
Outdated
Show resolved
Hide resolved
mediapicker/domain/src/main/java/org/wordpress/android/mediapicker/api/MediaPickerSetup.kt
Outdated
Show resolved
Hide resolved
…e permission requirement flag
|
Hey @irfano, I've addressed your comments and the PR's ready for a review. |
irfano
left a comment
There was a problem hiding this comment.
Thank you for all of your work and your patience with my review. 😁
I tested different MediaPickerSetups (only IMAGES and EVERYTHING), and both worked great. LGTM! 👍🏻
This PR updates the target SDK to version 33 and implements the new granular media access permissions (images, video, audio), described in the documentation.
On devices running older Android versions (< API 33), the original single
Storagepermission is requested, which gives access to all media. On versions 33 and up, new granular permissions are requested (images and video are requested in a single permission request, audio in another one).To test:
To test this PR, please prepare 2 devices/emulators with Android 33 and <33. Also make sure the devices have at least one image to display something (you can take a picture in the Camera app).
API 33:
music and audioappearsphotos and videosAPI <33:
photos, media and files