Conversation
Task failure message: "> Task :mediapicker:source-gif:processDebugAndroidTestManifest FAILED .../mediapicker/source-gif/build/intermediates/tmp/manifest/androidTest /debug/tempFile1ProcessTestManifest123.xml:5:5-72 Error: uses-sdk:minSdkVersion 1 cannot be smaller than version 21 declared in library [:mediapicker:domain] .../mediapicker/domain/build/intermediates/merged_manifest /debug/AndroidManifest.xml as the library might be using APIs not available in 1 Suggestion: use a compatible library with a minSdk of at most 1, or increase this project's minSdk version to at least 21, or use tools:overrideLibrary="org.wordpress.android.mediapicker.api" to force usage (may lead to runtime failures)"
This change suppressed both, the 'VectorRaster' and 'UnusedAttribute' Lint warnings for this drawable.
Also, as part of this change the previously disabled 'ObsoleteLintCustomCheck' error is removed as it is no longer needed.
…cker-Android into update/gradle-to-7.3.3-agp-to-7.0.4 � Conflicts: � settings.gradle
This is done because otherwise some WCAndroid client tests fail with an 'advanceUntilIdle' and/or 'advanceTimeBy' unresolved reference error.
| appcompatVersion = '1.4.1' | ||
| coreVersion = '1.7.0' | ||
| coroutinesVersion = '1.6.0' | ||
| coroutinesVersion = '1.5.2' |
There was a problem hiding this comment.
I was surprised by this, then I saw the commit message explaining why ( ❤️ ):
This is done because otherwise some WCAndroid client tests fail with an 'advanceUntilIdle' and/or 'advanceTimeBy' unresolved reference error.
There was a problem hiding this comment.
Thanks for the review @mokagio ! 🙏
I was surprised by this, then I saw the commit message explaining why ( ❤️ ):
Yes, @0nko made this upgrade on the previous #56 PR, but as it seems it is actually incompatible with WCAndroid, the WCAndoird Coroutines version, which currently is the 1.5.2. For some reason, the newest 1.6.0 version, comming from the library, overrides the one from the client. Then, this creates test failures as the newer version of Coroutines there were lots of major testing related changes that when upgrading need to be handled with care.
There was a problem hiding this comment.
BTW, I've been trying to smoke test the app locally, but I keep having Emulator issues etc. By now it's become personal, so I'll have to get to the bottom of it even if someone else reviews it before me.
Besides, while I'm confident in going through the sample app in monkey mode and in verifying WooCommerce Android builds when using the local composite build version of this, I don't have much to add when it comes to the technicalities of the upgrade. It's still best for someone that actually knows Android to look over this.
There was a problem hiding this comment.
👋 @mokagio !
Thanks for trying to smoke test the app! 🙏
BTW, I've been trying to smoke test the app locally, but I keep having Emulator issues etc.
Having fun with Emulators... 🤗 What kind of issues are you getting, maybe I can try to help?
By now it's become personal, so I'll have to get to the bottom of it even if someone else reviews it before me.
😅 Good luck, I hope you win this battle! 🤞
Besides, while I'm confident in going through the sample app in monkey mode and in verifying WooCommerce Android builds when using the local composite build version of this, I don't have much to add when it comes to the technicalities of the upgrade.
👍
It's still best for someone that actually knows Android to look over this.
I hear you, maybe I can drag @0nko here to help with a quick review, as always through shameless pinging... 😅
There was a problem hiding this comment.
I've checked the code and tested the sample app. Everything is looking good 👍.
There was a problem hiding this comment.
Thank you so much for checking and testing this PR @0nko ! 🙇
This PR upgrades
Gradle to 7.4&AGP to 7.1.1.It includes the following:
Gradleversion upgraded to7.3.3with the./gradlew wrapper --gradle-version=7.3.3 --distribution-type=allcommand.AGPversion upgrade to7.0.4(seesettings.gradlechange).Gradle 7.4&AGP 7.1.1.It suppresses the following Lint issues:
It resolves the following Lint issues:
It enables Lint warnings as errors for the following modules:
It disables the following Lint issues:
Besides the above, you can reference the
Gradle 7.4 & AGP 7.1.1PRs of the below clients for testing/verification purposes:NOTE: This is a draft PR because all
Gradle & AGPupgrade PRs need to be merged together.Merge Instructions
Ready for reviewand assign https://github.com/orgs/wordpress-mobile/teams/owl-team to it.To Test