This repository was archived by the owner on Feb 4, 2025. It is now read-only.
getAudioTypesOnly added to MimeTypes#1823
Merged
jd-alexander merged 5 commits intodevelopfrom Jan 15, 2021
Merged
Conversation
3 tasks
develric
approved these changes
Jan 13, 2021
Contributor
develric
left a comment
There was a problem hiding this comment.
Hey @jd-alexander , thanks for this PR. LGTM 👍 !
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1822
Findings
getAudioTypesOnlywas missing from MimeTypes. This functionality is now required by the Audio Block in Mobile Gutenberg because the Gutenberg Bridge's integration with the native media pickers need to filter media content by the audio MIME types only.Solution
To add this behavior to
MimeTypesTesting
A unit test is included in this solution that verifies that the getter works appropriately. For manual tests, you can create an instance of
MimeTypesand noticegetAudioTypesOnlyReviewing
Only 1 reviewer is needed but anyone can review.
Submitter Checklist
RELEASE-NOTES.txtif necessary.