Skip to content
This repository was archived by the owner on Feb 4, 2025. It is now read-only.

getAudioTypesOnly added to MimeTypes#1823

Merged
jd-alexander merged 5 commits intodevelopfrom
issue/1822get-audio-mime-types
Jan 15, 2021
Merged

getAudioTypesOnly added to MimeTypes#1823
jd-alexander merged 5 commits intodevelopfrom
issue/1822get-audio-mime-types

Conversation

@jd-alexander
Copy link
Copy Markdown
Contributor

Fixes #1822

Findings

getAudioTypesOnly was missing from MimeTypes. This functionality is now required by the Audio Block in Mobile Gutenberg because the Gutenberg Bridge's integration with the native media pickers need to filter media content by the audio MIME types only.

Solution

To add this behavior to MimeTypes

Testing

A unit test is included in this solution that verifies that the getter works appropriately. For manual tests, you can create an instance of MimeTypes and notice getAudioTypesOnly

Reviewing

Only 1 reviewer is needed but anyone can review.

Submitter Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
  • I have considered adding accessibility improvements for my changes.
  • If it's feasible, I have added unit tests.

@jd-alexander jd-alexander requested a review from develric January 7, 2021 23:51
@jd-alexander jd-alexander marked this pull request as ready for review January 7, 2021 23:51
Copy link
Copy Markdown
Contributor

@develric develric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jd-alexander , thanks for this PR. LGTM 👍 !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getAudioTypesOnly is missing from MimeTypes

2 participants