This repository was archived by the owner on Feb 4, 2025. It is now read-only.
ScanStore: Map ThreatModels based on types#1791
Merged
malinajirka merged 7 commits intodevelopfrom Dec 7, 2020
Merged
Conversation
…ssue/13326-threat-mapping-threat-types # Conflicts: # example/src/test/java/org/wordpress/android/fluxc/model/scan/threat/ThreatsMapperTest.kt
67 tasks
ashiagr
commented
Dec 2, 2020
Base automatically changed from
issue/13326-threat-mapping-context-deserialiser
to
develop
December 4, 2020 15:42
malinajirka
reviewed
Dec 4, 2020
Contributor
malinajirka
left a comment
There was a problem hiding this comment.
Great job @ashiagr! I've left a couple of comments - nitpicks and minor suggestions. Let me know what you think.
malinajirka
approved these changes
Dec 7, 2020
Contributor
malinajirka
left a comment
There was a problem hiding this comment.
Thank you for all the changes ;)! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: wordpress-mobile/WordPress-Android#13326
This PR converts
ThreatModelto a sealed class and maps threat models based on different types.Based on Calypso logic and threat types logic
threat.context != null) will provide codecontextto be displayed.threat.diff != null)will contain a gitdiffstring.threat.rows != null || 'Suspicious.Links' == threat.signature) will containrowsinformation.threat.extension != null) will containextensioninformation.If none of these, threat is mapped as a
GenericThreat.To test
That unit tests in
ThreatsMapperTestrun fine for different types of threats.Note
firstDetectedis sent asfirst_detected).