This repository was archived by the owner on Feb 4, 2025. It is now read-only.
Conversation
67 tasks
# Conflicts: # example/src/test/java/org/wordpress/android/fluxc/store/ScanStoreTest.kt
malinajirka
approved these changes
Nov 26, 2020
Contributor
malinajirka
left a comment
There was a problem hiding this comment.
Thanks @ashiagr! I've left two minor comments. It LGTM - feel free to merge it.
Contributor
|
Thanks for the changes, LGTM! ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: wordpress-mobile/WordPress-Android#13326
This PR stores scan state into DB.
Currently it does not save credentials and threats and focuses mainly on storing scan progress status.
To test
That scan progress status is correctly saved into the DB.
Notes
Note that out of 4 different scan states (
IDLE,SCANNING,PROVISIONING,UNAVAILABLE) onlyIDLEandSCANNINGstates return the progress status.IDLEstate: returnsmost_recentstatus (currentisnull)SCANNINGstate: returnscurrentstatus (most_recentisnull)Since either
most_recentorcurrentis valid for these states, fields likeprogress,isInitial,startDateare not created separately formost_recentandcurrent.RewindStatusCredentialsfor storingCredentialsfor scan functionality as both refer to the same set of credentials. CurrentlyRewindStatusCredentialsis not used anywhere in WordPress-Android, will consider storing credentials returned in scan state response later when we really need it.