This repository was archived by the owner on Feb 4, 2025. It is now read-only.
Extends FETCH_BLOCK_LAYOUTS action for self-hosted sites#1702
Merged
Extends FETCH_BLOCK_LAYOUTS action for self-hosted sites#1702
Conversation
Merged
3 tasks
chipsnyder
reviewed
Oct 9, 2020
Contributor
chipsnyder
left a comment
There was a problem hiding this comment.
Code looks good 👍 I was hoping to finish my review this afternoon but got stuck with an errand that took longer than expected. I'll finish up the review first thing Monday if that's ok 🙏
chipsnyder
approved these changes
Oct 12, 2020
Contributor
chipsnyder
left a comment
There was a problem hiding this comment.
Tested with wordpress-mobile/WordPress-Android#13017 (review) everything works well 👍
chipsnyder
reviewed
Oct 12, 2020
| } | ||
|
|
||
| @Test | ||
| public void testFetchBlockLayouts() throws InterruptedException { |
Contributor
There was a problem hiding this comment.
I like the addition of the tests :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#2455
Description
This PR fetches the Block Layouts for self-hosted sites from
/wpcom/v2/common-block-layoutsTo test
This can be tested with wordpress-mobile/WordPress-Android#13017
or by running the
testFetchBlockLayouts()test.