Use global scope for global operation in insights management#9742
Merged
malinajirka merged 1 commit intofeature/manage_insights_readonlyfrom Apr 29, 2019
Merged
Conversation
Contributor
|
Looks and works as expected. Thanks! |
malinajirka
approved these changes
Apr 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug when adding a new block to insights for the first time, it would get stuck in an infinite loading state. This was caused by the coroutine getting stopped because the ViewModel was closed when we have saved the Insights management activity (activity finish triggers ViewModel clean which cancels the coroutine). To fix this I'm replacing a coroutine with a local scope with the one with global scope. This guarantees that the coroutine will always finish.
To test: