Point to GB mobile with JitPack workaround#9052
Merged
Conversation
Contributor
|
Tested with building from src code and from bundle, and both worked OK! Note that I had to remove the folder |
Contributor
Author
That's fair. The code in current wpandroid develop points to a state of the gutenberg-mobile repo where the react-native-aztec folder holds code from the git submodule. But, that folder is now overwritten by the git subtree. Git doesn't automatically delete the checkout out already in your tree so, it complains. It's fine to delete the folder and then let git checkout do its thing. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a recent change in GB mobile and a JitPack issue, the binary builds for gutenberg-mobile (and react-native-aztec) were broken. This PR uses a workaround until the issue is fixed.
To test:
Build and open a post in GB mobile. It should work as normal. Also, Travis/CircleCI should be green on this.
Update release notes:
RELEASE-NOTES.txt.