Move insights up and down in the list#9047
Merged
0nko merged 21 commits intofeature/manage_insights_readonlyfrom Mar 22, 2019
Merged
Move insights up and down in the list#90470nko merged 21 commits intofeature/manage_insights_readonlyfrom
0nko merged 21 commits intofeature/manage_insights_readonlyfrom
Conversation
Contributor
Generated by 🚫 Danger |
0nko
suggested changes
Mar 20, 2019
Contributor
0nko
left a comment
There was a problem hiding this comment.
This is pretty cool :). I've found a couple of quirks:
- When you tap on the overflow menu of a card and dismiss it, it's not possible to tap it again. You have to first tap a different card's menu button and then it works again.
- When you move the Latest Post Summary down and use PTR, the screen is automatically scrolled down to that card for some reason.
wpmobilebot
reviewed
Mar 21, 2019
...a/org/wordpress/android/ui/stats/refresh/lists/sections/insights/usecases/CommentsUseCase.kt
Outdated
Show resolved
Hide resolved
…ights_up_and_down
Contributor
Author
|
@0nko thanks for the check 👍 , I think I've fixed both the issues (at least I cannot reproduce them anymore) |
0nko
approved these changes
Mar 22, 2019
Contributor
0nko
left a comment
There was a problem hiding this comment.
Confirmed, the issues are fixed and the menu works great! Thanks! 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8953
This is related to the FluxC PR - wordpress-mobile/WordPress-FluxC-Android#1088
This PR adds an overflow menu to each Title on the Insights tab. This menu contains button to move the item up, down or remove it from the list.
To test:
Move up,Move downandRemoveMove upactionMove downaction