Focus on title when the new post loads#8826
Merged
Conversation
- Set focus on title on the new post
Contributor
Generated by 🚫 Danger |
| mIsNewPost = getArguments().getBoolean(ARG_IS_NEW_POST); | ||
| if (mIsNewPost) { | ||
| mTitle.requestFocus(); | ||
| showImplicitKeyboard(); |
Contributor
There was a problem hiding this comment.
Is it required the call to showImplicitKeyboard?
I've commented it and didn't notice any difference testing on emulators.
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing me out that. @daniloercoli, probably we can remove it.
Contributor
Author
There was a problem hiding this comment.
Hey @daniloercoli , I checked on mobile device Nexus 5x, 8.1 Android and it can't work without showImplicitKeyboard
Contributor
Contributor
There was a problem hiding this comment.
just to double check: tested the same on
- Nexus 4 emulator with Android 5.1.1:
- Nexus 5 emulator with Android 7.0
Observed the same behavior as above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Based on the issue .
On Gutenberg
Note: I have a problem to convert demonstration of this feature into .gif :(